Skip to content

Some improvements to the release scripts #3197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .vsts-ci/azure-pipelines-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,15 @@ resources:
type: github
endpoint: ComplianceGHRepo
name: PowerShell/Compliance
pipelines:
- pipeline: PowerShellEditorServices
source: PowerShellEditorServices
trigger:
branches:
- master
- releases/*
- changelog*
- refs/tags/*

jobs:

Expand Down
4 changes: 3 additions & 1 deletion .vsts-ci/templates/release-general.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ steps:
targetType: filePath
filePath: ./vscode-powershell/tools/releaseBuild/setVstsVariables.ps1

# TODO: Replace this with an upstream trigger.
# TODO: Remove this when satisfied with added trigger.
- task: PowerShell@2
displayName: 'Find PowerShellEditorServices build'
env:
Expand Down Expand Up @@ -54,6 +54,8 @@ steps:

- template: EsrpSign.yml@ComplianceRepo
parameters:
# TODO: $[in(variables['Build.Reason'], 'Manual', 'ResourceTrigger')]
shouldSign: true
buildOutputPath: '$(Build.ArtifactStagingDirectory)/vscode-powershell'
signOutputPath: '$(Build.ArtifactStagingDirectory)/Signed'
alwaysCopy: true # So publishing works
Expand Down
2 changes: 1 addition & 1 deletion tools/ChangelogTools.psm1
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ filter Skip-IgnoredChange
$Change,

[Parameter()]
[string]
[string[]]
$User,

[Parameter()]
Expand Down
Loading