Fix docs Amplitude page views missing path property#21374
Merged
Conversation
Two issues caused most Page View: Docs New events to lack the path property: 1. Amplitude's defaultTracking.pageViews fired auto-tracked events on every SPA navigation without the custom path property, while the manual trackPageView() (which sets path) only ran once on init. 2. observeRouteChanges() only supported a single callback, so it couldn't be reused for both Unify and Amplitude tracking. Changes: - Disable defaultTracking.pageViews (set to false) - Hook trackPageView into observeRouteChanges so it fires on every route change - Refactor observeRouteChanges to support multiple callbacks - Fix window.href -> window.location.href (was always undefined) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
aaazzam
requested review from
chrisguidry,
cicdw,
desertaxle and
zzstoatzz
as code owners
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
desertaxle
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
defaultTracking.pageViews— Amplitude's auto-trackedPage View: Docs Newevents don't include the custompathproperty, producing the 71% of events withpath = (none). Replaced with the manualtrackPageView()which always setspath: window.location.pathname.trackPageViewon every SPA navigation viaobserveRouteChanges()instead of only once on init viasetTimeout.observeRouteChangesto support multiple callbacks so both Unify and Amplitude can listen for route changes.window.href→window.location.href(window.hrefis undefined).🤖 Generated with Claude Code