Reduce redundant deployments requests on deployments page#21427
Open
jeevan6996 wants to merge 1 commit intoPrefectHQ:mainfrom
Open
Reduce redundant deployments requests on deployments page#21427jeevan6996 wants to merge 1 commit intoPrefectHQ:mainfrom
jeevan6996 wants to merge 1 commit intoPrefectHQ:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #20397
this PR removes a redundant deployments request in the deployments route by relying on paginated response metadata for empty-state/count handling.
Changes
ui-v2/src/routes/deployments/index.tsxcountplus active filtersui-v2/src/routes/deployments/utils.tsui-v2/src/routes/deployments/utils.test.tsTesting
npm run test -- src/routes/deployments/utils.test.tslibsimdjson.31.dylibmissing)