Allow a module to be updated even if it does not have a config.xml file#1547
Merged
Conversation
Quetzacoalt91
changed the title
Hlavtox
previously approved these changes
Dec 12, 2025
Hlavtox
left a comment
Hlavtox
left a comment
Contributor
There was a problem hiding this comment.
This is good. The config.xml file is only required for addons. Shops will create config_isocodeoflanguage.xml automatically. :-)
Nakahiru
previously approved these changes
Jan 7, 2026
ga-devfront
previously approved these changes
Jan 7, 2026
Quetzacoalt91
dismissed stale reviews from ga-devfront and Nakahiru
via
January 12, 2026 11:04
0dc483e
Quetzacoalt91
force-pushed
the
config-xml-check
branch
from
January 12, 2026 11:04
5a665ef to
0dc483e
Compare
|
ga-devfront
approved these changes
Jan 12, 2026
AureRita
approved these changes
Jan 12, 2026
AureRita
left a comment
AureRita
left a comment
Contributor
There was a problem hiding this comment.
Thank you for your PR, I tested it and it seems to works as you can see :
Capture.video.du.2026-01-12.12-24-34.mp4
Tested from :
8.1.4 to 8.2.3 (each version on Open source and with module ps_mbo)
9.0.0 to 9.0.2
Because the PR seems to works as expected, It's QA ✔️
Thank you
AureRita
added
QA ✔️
github-project-automation
Bot
moved this from Ready for review
to Merged
in PR Dashboard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
config.xmldoes not exist. Because we don't rely anymore on the XML content the related check can be removed, allowing more modules to be updated.