Skip to content

[FIX] PHP deprecation notices break JSON responses in AJAX endpoints#1584

Merged
ga-devfront merged 2 commits into
PrestaShop:devfrom
ga-devfront:fix/issue-SCE-1024
Jan 9, 2026
Merged

[FIX] PHP deprecation notices break JSON responses in AJAX endpoints#1584
ga-devfront merged 2 commits into
PrestaShop:devfrom
ga-devfront:fix/issue-SCE-1024

Conversation

@ga-devfront

@ga-devfront ga-devfront commented Jan 6, 2026

Copy link
Copy Markdown
Contributor
Questions Answers
Description? When running the autoupgrade module, PHP errors, warnings, and deprecation notices from vendor libraries or other sources are being output as HTML before JSON responses. This breaks the JSON parsing in JavaScript and causes operations to fail.
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Internal issue
Sponsor company @PrestaShopCorp
How to test?

To test use PS tag (for docker) = 9.0.0-8.4
and for .ini file with

display_errors = On
error_reporting = E_ALL

@github-project-automation github-project-automation Bot moved this to Ready for review in PR Dashboard Jan 6, 2026
@ga-devfront ga-devfront added the bug Type: Bug fix label Jan 6, 2026
@ga-devfront ga-devfront changed the title fix: add ob start and clean in ajax upgradetab and error case for dep… [FIX] PHP deprecation notices break JSON responses in AJAX endpoints Jan 6, 2026
@sonarqubecloud

sonarqubecloud Bot commented Jan 8, 2026

Copy link
Copy Markdown

@ga-devfront ga-devfront added this to the 7.6.0 milestone Jan 8, 2026

@AureRita AureRita left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ga-devfront

Thank you for your PR, I tested it and it seems to works as you can see :

Capture.video.du.2026-01-09.16-12-01.mp4

check of logs :

Capture.video.du.2026-01-09.17-08-32.mp4

check of php :

Capture.video.du.2026-01-09.16-02-40.mp4

Starting the setup of an upgrade :

Capture.video.du.2026-01-09.17-08-32.mp4

Tested from :
docker 9.0.0-8.4

Because the PR seems to works as expected, It's QA ✔️

Thank you

@AureRita AureRita added QA ✔️ Status: Check done, Code approved and removed waiting for QA labels Jan 9, 2026
@ga-devfront
ga-devfront merged commit db869e0 into PrestaShop:dev Jan 9, 2026
56 checks passed
@ga-devfront
ga-devfront deleted the fix/issue-SCE-1024 branch January 9, 2026 16:48
@github-project-automation github-project-automation Bot moved this from Ready for review to Merged in PR Dashboard Jan 9, 2026
@ps-jarvis ps-jarvis moved this from Merged to Ready for review in PR Dashboard Jan 9, 2026
@mcaldex

mcaldex commented Jan 26, 2026

Copy link
Copy Markdown

hi @Quetzacoalt91 , when will version 7.6.0 be released?
This fix is essential, without it the module is unusable on 99%+ of installations I think.

@Quetzacoalt91

Quetzacoalt91 commented Jan 26, 2026

Copy link
Copy Markdown
Member

Fortunately, not this many environments are concerned by this issue.

This PR solves the issue only for stores which are configured like this, in development mode:

display_errors = On
error_reporting = E_ALL

In the meantime, you may switch off display_errors or decrease the verbosity of the error report. I expect at least a month while we finish the rest of the expected changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Type: Bug fix QA ✔️ Status: Check done, Code approved

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants