Skip to content

Speed up execution of files updates by moving files instead of copying them#1599

Merged
Quetzacoalt91 merged 1 commit into
PrestaShop:devfrom
Quetzacoalt91:speed-up-files-step-by-moving-files
Jan 20, 2026
Merged

Speed up execution of files updates by moving files instead of copying them#1599
Quetzacoalt91 merged 1 commit into
PrestaShop:devfrom
Quetzacoalt91:speed-up-files-step-by-moving-files

Conversation

@Quetzacoalt91

Copy link
Copy Markdown
Member
Questions Answers
Description? During the update of files, move them instead of copying them which is a really fast operation when the source and destination are on the same disk partition.
Type? improvement
BC breaks? Nope
Deprecations? Nope
Fixed ticket? /
Sponsor company @PrestaShopCorp
How to test? Check the time needed to run the updates, especially until the end of the update of files. You should expect the time taken to be cut in half.

@Quetzacoalt91 Quetzacoalt91 self-assigned this Jan 15, 2026
@Quetzacoalt91 Quetzacoalt91 added the enhancement Type: Improvement label Jan 15, 2026
@github-project-automation github-project-automation Bot moved this to Ready for review in PR Dashboard Jan 15, 2026
@Quetzacoalt91 Quetzacoalt91 changed the title Speed up execution of files updates by moving files instead of copying Speed up execution of files updates by moving files instead of copying them Jan 15, 2026
@sonarqubecloud

Copy link
Copy Markdown

@Hlavtox Hlavtox left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should work good, but watch out for permissions. Rename needs write+execute rights for both orig and dest directories. It should work just fine, but could be more sensitive.

@Quetzacoalt91

Copy link
Copy Markdown
Member Author

It should just work indeed as we need to change the dest anyway and Update Assistant is the one who brought the orig files as well by unzipping the release.

I had another concern which the probability to use the same file a second time, but that's not the case. 👍

@AureRita AureRita self-assigned this Jan 16, 2026
M0rgan01
M0rgan01 approved these changes Jan 16, 2026

@AureRita AureRita left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @

Thank you for your PR, I tested it and it seems to works as you can see :

From 9.0.0 classic to 9.0.2 on localhost
Before PR : 1m30
After PR : 1m20

8.1.4 to 9.0.2 on localhost
before PR : 1min58
After PR : 1min50

8.2.3 to 9.0.2 on docker :
before PR : 3min30
After PR : 2min02

Because the PR seems to works as expected, It's QA ✔️

Thank you

@AureRita AureRita added QA ✔️ Status: Check done, Code approved and removed waiting for QA labels Jan 16, 2026
@Quetzacoalt91 Quetzacoalt91 added this to the 7.6.0 milestone Jan 20, 2026
@Quetzacoalt91
Quetzacoalt91 merged commit 25a6038 into PrestaShop:dev Jan 20, 2026
56 checks passed
@Quetzacoalt91
Quetzacoalt91 deleted the speed-up-files-step-by-moving-files branch January 20, 2026 09:08
@github-project-automation github-project-automation Bot moved this from Ready for review to Merged in PR Dashboard Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Type: Improvement QA ✔️ Status: Check done, Code approved

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants