Skip to content

Add virtual_combinations migration to 9.2.0 upgrade SQL#1855

Open
PrestaEdit wants to merge 1 commit into
PrestaShop:7.6.xfrom
PrestaEdit:feat-virtual-combinations-9.2.0
Open

Add virtual_combinations migration to 9.2.0 upgrade SQL#1855
PrestaEdit wants to merge 1 commit into
PrestaShop:7.6.xfrom
PrestaEdit:feat-virtual-combinations-9.2.0

Conversation

@PrestaEdit

@PrestaEdit PrestaEdit commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Companion to PrestaShop/PrestaShop#41825 (new virtual_combinations product type).

Existing shops need this upgrade SQL appended to upgrade/sql/9.2.0.sql:

  • add id_product_attribute to product_download (0 = product level)
  • relax UNIQUE(id_product) -> UNIQUE(id_product, id_product_attribute)
  • extend product.product_type enum with virtual_combinations

The core PR changes install-dev/data/db_structure.sql for fresh installs; this covers upgrades.

🤖 Generated with Claude Code

@github-project-automation github-project-automation Bot moved this to Ready for review in PR Dashboard Jun 25, 2026
@PrestaEdit PrestaEdit mentioned this pull request Jun 25, 2026
Open
@PrestaEdit
PrestaEdit force-pushed the feat-virtual-combinations-9.2.0 branch from cd94c31 to 87cddda Compare June 25, 2026 12:29
@ps-jarvis ps-jarvis added the Waiting for QA Status: Action required, Waiting for test feedback label Jun 25, 2026
@ps-jarvis ps-jarvis moved this from Ready for review to To be tested in PR Dashboard Jun 25, 2026
Quetzacoalt91
Quetzacoalt91 requested changes Jun 25, 2026
View reviewed changes

@Quetzacoalt91 Quetzacoalt91 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, however, can you please target the branch 7.6.x?

@Quetzacoalt91 Quetzacoalt91 removed the Waiting for QA Status: Action required, Waiting for test feedback label Jun 25, 2026
@PrestaEdit

PrestaEdit commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

The main issue on PrestaShop side is not yet merged ; it's fair to handle this version right now ? :)

@Quetzacoalt91

Quetzacoalt91 commented Jun 25, 2026

Copy link
Copy Markdown
Member

The PR will be blocked until the PR on the core is merged, but a release from the branch 7.6.x will cover the compatibility with PS 9.2.0

@PrestaEdit
PrestaEdit force-pushed the feat-virtual-combinations-9.2.0 branch from 87cddda to eeb3c34 Compare June 25, 2026 14:21
@PrestaEdit
PrestaEdit changed the base branch from dev to 7.6.x June 25, 2026 14:21
@PrestaEdit

PrestaEdit commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the review! Done — rebased onto 7.6.x and retargeted the PR to that branch (the migration is appended to the end of upgrade/sql/9.2.0.sql as it stands on 7.6.x).

@ps-jarvis ps-jarvis added the Waiting for QA Status: Action required, Waiting for test feedback label Jun 25, 2026
@PrestaEdit @claude
Add per-combination virtual flag + downloadable files migration to 9.2.0
40ccdad 
Companion to PrestaShop/PrestaShop#41825: adds product_attribute.is_virtual
(per-combination virtual flag) and id_product_attribute to product_download
(one downloadable file per combination), relaxing its unique key.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@PrestaEdit

PrestaEdit commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

Updated following the design pivot (discussion #41826): the migration now adds product_attribute.is_virtual (per-combination virtual flag) instead of a new product_type enum value, and keeps the product_download per-combination changes.

@PrestaEdit
PrestaEdit force-pushed the feat-virtual-combinations-9.2.0 branch from eeb3c34 to 40ccdad Compare June 29, 2026 14:01
@sonarqubecloud

sonarqubecloud Bot commented Jun 29, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@PrestaEdit
PrestaEdit requested a review from Quetzacoalt91 June 29, 2026 14:08
@Quetzacoalt91 Quetzacoalt91 added Blocked Status: The issue is blocked by another task and removed Waiting for QA Status: Action required, Waiting for test feedback labels Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Quetzacoalt91 Quetzacoalt91 Awaiting requested review from Quetzacoalt91

Assignees

No one assigned

Labels

Blocked Status: The issue is blocked by another task Migration script

Projects

PR Dashboard
Status: To be tested

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PrestaEdit @Quetzacoalt91 @ps-jarvis