State what the phone number is used for on the checkout form#100
Open
boo-code wants to merge 2 commits into
Open
State what the phone number is used for on the checkout form#100boo-code wants to merge 2 commits into
boo-code wants to merge 2 commits into
Conversation
Collaborator
|
Hello @boo-code! This is your first pull request on ps_onepagecheckout repository of the PrestaShop project. Thank you, and welcome to this Open Source community! |
Collaborator
|
This pull request seems to contain new translation strings. I have summarized them below to ease up review:
(Note: this is an automated message, but answering it will reach a real human) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AddressFieldsFormatTraitthrough theFormFieldavailableValues.commentslot the theme'sform-fields.tplalready renders as aform-textline (no theme or JS change). Item 4 of #96.vendor/bin/phpunit -c tests/php/phpunit.xml --filter AddressFieldsFormatTraitTest(asserts the comment on the phone field and its absence on other fields). On a 9.2 checkout the hint renders under the Phone input next to the "Optional" marker — verified live.