Skip to content

feat: [SPE-95] Remove prefix for invoiceFields#27

Draft
kevin-carangeot wants to merge 3 commits into
mainfrom
feat/SPE-95
Draft

feat: [SPE-95] Remove prefix for invoiceFields#27
kevin-carangeot wants to merge 3 commits into
mainfrom
feat/SPE-95

Conversation

@kevin-carangeot

@kevin-carangeot kevin-carangeot commented Apr 13, 2026

Copy link
Copy Markdown
Contributor
Questions Answers
Description? Previously, billing address fields were distinguished from delivery fields by prefixing their names with invoice_ (e.g. invoice_firstname, invoice_id_country). This prefix is now stripped at the PHP mapping stage (mapFieldsByGroup() in OnePageCheckoutForm), so templates and JS always receive clean, unprefixed field names. Disambiguation is handled by DOM section context instead. This PR must be paired with hummingbirdFork#40 which updates the Smarty templates accordingly.
Type? refacto
BC breaks? yes — external code (custom modules, overrides) relying on invoice_ prefixed field names in form submissions or invoiceFields template variables must be updated.
Deprecations? no
Fixed ticket? SPE-95 (internal)
How to test? 1. Go to checkout with 2+ saved addresses and select different delivery and billing addresses → verify the correct addresses are submitted.
2. Go to checkout with 0 saved addresses → fill in the inline delivery form, then the inline billing form → verify both addresses are correctly created.
3. Open the delivery modal, change the country → verify only the delivery section refreshes.
4. Open the billing modal, change the country → verify only the billing section refreshes.
5. Toggle "use same address" → verify the billing section is correctly enabled/disabled.
6. Delete an address from delivery list, then from billing list → verify the correct address type is deleted.

@kevin-carangeot kevin-carangeot self-assigned this Apr 13, 2026
@ps-jarvis

Copy link
Copy Markdown
Collaborator

Hello @kevin-carangeot!

This is your first pull request on ps_onepagecheckout repository of the PrestaShop project.

Thank you, and welcome to this Open Source community!

@github-project-automation github-project-automation Bot moved this to Ready for review in PR Dashboard Apr 13, 2026
@ThbPS

ThbPS commented Apr 17, 2026

Copy link
Copy Markdown
Collaborator

suggestion(non-blocking)

Je propose de merger cette PR à la fin pour éviter des conflits et effets de bords
Sachant que ce ticket n'est pas bloquant

@ThbPS ThbPS marked this pull request as draft June 2, 2026 10:50
Base automatically changed from SPE-72/opc-migration to main June 9, 2026 11:20
@ThbPS ThbPS changed the base branch from main to dev June 10, 2026 06:14
@ThbPS ThbPS changed the base branch from dev to main June 10, 2026 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready for review

Development

Successfully merging this pull request may close these issues.

4 participants