Skip to content

bug: merge dry-run misses review artifact consistency failures #991

@robertDouglass

Description

@robertDouglass

Summary

During mission auth-local-trust-and-multi-process-hardening-01KQW587, spec-kitty merge --dry-run did not report a review-artifact consistency blocker that the subsequent real merge enforced as REJECTED_REVIEW_ARTIFACT_CONFLICT.

The dry-run looked merge-ready, but the real merge required manual approved review-cycle-N.md artifacts because the latest review-cycle files for some WPs still carried rejected verdicts.

Expected behavior

spec-kitty merge --dry-run and real merge should share the same preflight gates for review artifact consistency. If real merge will reject with REJECTED_REVIEW_ARTIFACT_CONFLICT, dry-run should report the same blocker in human and JSON output.

Actual behavior

Dry-run did not surface the blocker. Real merge stopped later, after the operator had already treated the mission as merge-ready.

Impact

This weakens dry-run as a trusted readiness signal and pushes deterministic validation into the irreversible merge path. Agents/operators have to discover and patch review artifacts manually.

Related

Related to stale rejected review-cycle state tracking in #904, but this issue is specifically about dry-run parity with the real merge gate.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingworkflowWorkflow/UX improvements

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions