Skip to content

Fix ReDoS#3078

Merged
RunDevelopment merged 3 commits into
PrismJS:masterfrom
ready-research:master
Sep 15, 2021
Merged

Fix ReDoS#3078
RunDevelopment merged 3 commits into
PrismJS:masterfrom
ready-research:master

Conversation

@ready-research

Copy link
Copy Markdown
Contributor

Fix ReDoS

* [Security] Fix ReDoS

Fix ReDoS
@github-actions

github-actions Bot commented Sep 14, 2021

Copy link
Copy Markdown

JS File Size Changes (gzipped)

A total of 1 files have changed, with a combined diff of +5 B (+0.5%).

Details
file master pull size diff % diff
components/prism-markup.min.js 1.03 KB 1.04 KB +5 B +0.5%

Generated by 🚫 dangerJS against 243390e

@RunDevelopment

Copy link
Copy Markdown
Member

components/prism-markup.min.js has a new line at the end for some reason. That's why the build fails.

@ready-research

ready-research commented Sep 14, 2021

Copy link
Copy Markdown
Contributor Author

@RunDevelopment Is it okay now?
Please validate the huntr link by clicking on mark as valid, and also you can confirm the fix. Thank you.

@RunDevelopment

Copy link
Copy Markdown
Member

@ready-research That new line is still present. Your last commit was empty.

@ready-research

Copy link
Copy Markdown
Contributor Author

@RunDevelopment I am not seeing any new line in components/prism-markup.min.js. Can you please edit that if you have permission to do that? Or feel free to raise a new pull to resolve this issue. Thank you.

@RunDevelopment RunDevelopment merged commit 0ff371b into PrismJS:master Sep 15, 2021
@ready-research

Copy link
Copy Markdown
Contributor Author

@RunDevelopment Can you please confirm the fix in huntr?

@RunDevelopment

Copy link
Copy Markdown
Member

Done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants