fix: Adjust net5.0 targetframework to fix assets packaging #2542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reunion 0.8 uses the TargetFramework verbatim to package additional content, which is different from what nuget infers. Using `net5.0-windows10.0.18362.0` is transformed to `net5.0-windows10.0.18362` by nuget, but the mrt packaging still uses `net5.0-windows10.0.18362.0` causing a build failure where some resource files cannot be found.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dansiegel
approved these changes
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Reunion 0.8 uses the TargetFramework verbatim to package additional content, which is different from what nuget infers.
Using
net5.0-windows10.0.18362.0is transformed tonet5.0-windows10.0.18362by nuget, but the mrt packaging still usesnet5.0-windows10.0.18362.0causing a build failure where some resource files cannot be found.API Changes
List all API changes here (or just put None), example:
Added: None
Changed: None
Behavioral Changes
None
PR Checklist
Has tests (if omitted, state reason in description)