Skip to content

Cleanup #3051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jan 20, 2024
Merged

Cleanup #3051

merged 16 commits into from
Jan 20, 2024

Conversation

dansiegel
Copy link
Member

@dansiegel dansiegel commented Jan 18, 2024 •
edited
Loading

Description of Change

Adding additional XML docs and removing AssemblyMetadata

Bugs Fixed

API Changes

none

Behavioral Changes

  • NavigationParamters GetValues will remove null values

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard

@dansiegel dansiegel merged commit 214120b into master Jan 20, 2024
@dansiegel dansiegel deleted the dev/ds/cleanup branch January 20, 2024 19:31
@dansiegel dansiegel mentioned this pull request Jan 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianlagunas brianlagunas Awaiting requested review from brianlagunas brianlagunas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] new assembly metadata of #3038 breaks build [BUG] Navigation is animated when parameters have turned animation off
1 participant
@dansiegel