Skip to content

Conversation

lucacivale
Copy link
Contributor

@lucacivale lucacivale commented Jun 10, 2024

Description of Change

Added LayoutRegionAdapter to support Microsoft.Controls.Layout

Bugs Fixed

#3159

API Changes

Added:

public class LayoutRegionAdapter : RegionAdapterBase<Layout>

Behavioral Changes

N/a

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard

…rols.Layout instead of Maui.Controls.Compatibility.Layout PrismLibrary#3159
Copy link
Member

@dansiegel dansiegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I agree that the Microsoft.Maui.Controls.Layout should be supported. I also don't want to remove support for the Compatibility version. If you can add back the support so that both are supported we can go ahead and merge this.

…rols.Layout instead of Maui.Controls.Compatibility.Layout
Copy link
Member

@dansiegel dansiegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants