-
Notifications
You must be signed in to change notification settings - Fork 1.2k
2812 enhance swish and efficientnet #2813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
wyli
reviewed
Aug 20, 2021
Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
…into 2812-enhance-swish
Signed-off-by: Yiheng Wang <[email protected]>
/build |
/build |
wyli
approved these changes
Aug 24, 2021
Signed-off-by: Yiheng Wang <[email protected]>
…into 2812-enhance-swish
/build |
wyli
approved these changes
Aug 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, there are some minor style issues reported here https://github.com/Project-MONAI/MONAI/pull/2813/checks?check_run_id=3419685439 please help fix them here or in another PR
Signed-off-by: Yiheng Wang <[email protected]>
…into 2812-enhance-swish
Signed-off-by: Yiheng Wang <[email protected]>
…into 2812-enhance-swish
/build |
1 similar comment
/build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yiheng Wang [email protected]
Fixes #2812 .
This PR also enhances efficientnet via:
EfficientNetBNFeatures
class, which is used to build a backbone for segmentation and object detection tasks._load_state_dict
, and remove the hard requirement ofin_channels = 3
. Now, the network within_channels != 3
will load weights for all layers except the first conv layer.The enhancement refers to: https://github.com/rwightman/pytorch-image-models
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage
../runtests.sh --quick --unittests
.make html
command in thedocs/
folder.