Skip to content

ShiftIntensityd, RandShiftIntensityd #2839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 25, 2021

Conversation

rijobro
Copy link
Contributor

@rijobro rijobro commented Aug 25, 2021

Description

Torch transform for ShiftIntensityd and RandShiftIntensityd. Requires https://github.com/Project-MONAI/MONAI/pull/2838/files.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.

Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Richard Brown <[email protected]>
@rijobro rijobro requested review from wyli and Nic-Ma August 25, 2021 10:15
@rijobro
Copy link
Contributor Author

rijobro commented Aug 25, 2021

@Nic-Ma This should be the last of your required BRATS transforms - #2819 (comment).

Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, put some minor comments.

Thanks.

@rijobro
Copy link
Contributor Author

rijobro commented Aug 25, 2021

/build

@rijobro
Copy link
Contributor Author

rijobro commented Aug 25, 2021

@wyli do I have the rights to trigger blossom-ci by using /build?

@rijobro rijobro enabled auto-merge (squash) August 25, 2021 15:02
@wyli
Copy link
Contributor

wyli commented Aug 25, 2021

/build

1 similar comment
@wyli
Copy link
Contributor

wyli commented Aug 25, 2021

/build

@rijobro rijobro merged commit 26f8446 into Project-MONAI:dev Aug 25, 2021
@rijobro rijobro deleted the shift_intensityd branch August 26, 2021 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants