Skip to content

3613 windows test error #3615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

3613 windows test error #3615

wants to merge 2 commits into from

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Jan 8, 2022

Signed-off-by: Wenqi Li [email protected]

Fixes #3613

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli mentioned this pull request Jan 8, 2022
Closed
@wyli
Copy link
Contributor Author

wyli commented Jan 8, 2022

/build

@wyli wyli marked this pull request as ready for review January 8, 2022 21:07
@wyli wyli requested a review from Nic-Ma January 8, 2022 21:08
Nic-Ma
Nic-Ma previously approved these changes Jan 9, 2022
View reviewed changes
@Nic-Ma Nic-Ma self-requested a review January 9, 2022 11:07
@Nic-Ma Nic-Ma dismissed their stale review January 9, 2022 11:08

pending as I found some permission related thing.

@wyli
Copy link
Contributor Author

wyli commented Jan 10, 2022

/build

@wyli
Copy link
Contributor Author

wyli commented Jan 10, 2022

the exception is at exiting the context, this PR won't fix the issue, closing it.

@wyli wyli closed this Jan 10, 2022
@wyli wyli deleted the 3613-windows branch January 10, 2022 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_persistentdataset_dist error on windows
2 participants
@wyli @Nic-Ma