Skip to content

Sliding window inference that supports multiple zoomed outputs #4363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 35 commits into from
May 28, 2022
Merged

Sliding window inference that supports multiple zoomed outputs #4363

merged 35 commits into from
May 28, 2022

Conversation

@Can-Zhao
Copy link
Collaborator

@Can-Zhao Can-Zhao commented May 26, 2022 •
edited
Loading

Fixes #4299 .

Description

Add sliding window inference that supports multiple zoomed outputs.
Equivalent to existing sliding window inferer if predictor gives single output.

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Can-Zhao Can-Zhao added this to the Detection module [P0] milestone May 26, 2022
@Can-Zhao
Copy link
Collaborator Author

Can-Zhao commented May 26, 2022

/black

@Can-Zhao
Copy link
Collaborator Author

Can-Zhao commented May 26, 2022

/black

@Can-Zhao Can-Zhao marked this pull request as ready for review May 27, 2022 00:48
@Can-Zhao Can-Zhao requested review from Nic-Ma and wyli May 27, 2022 00:48
@wyli
Copy link
Contributor

wyli commented May 27, 2022 •
edited
Loading

This looks nice, I'd recommend merging it into monai.inferer, please review/verify my pull request to this PR... Can-Zhao#6

@wyli
Copy link
Contributor

wyli commented May 28, 2022

/build

@wyli wyli enabled auto-merge (squash) May 28, 2022 16:39
@wyli wyli disabled auto-merge May 28, 2022 17:01
@wyli wyli enabled auto-merge (squash) May 28, 2022 17:01
wyli
wyli approved these changes May 28, 2022
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non breaking enhancement inferer, multiresolution multioutput support

@wyli wyli merged commit ba2309c into Project-MONAI:dev May 28, 2022
@Can-Zhao Can-Zhao deleted the sliding branch May 28, 2022 19:40
@Can-Zhao Can-Zhao linked an issue May 29, 2022 that may be closed by this pull request
Sliding window inferer for detection #3777
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma Nic-Ma is a code owner

Assignees

No one assigned

Labels

Feature request

Projects

None yet

Milestone

Detection module [P0]

Development

Successfully merging this pull request may close these issues.

About the sliding_window_inference Sliding window inferer for detection

3 participants

@Can-Zhao @wyli @monai-bot