Skip to content

Conversation

@MMelQin
Copy link
Collaborator

@MMelQin MMelQin commented Oct 31, 2025

No description provided.

@MMelQin MMelQin requested a review from Copilot October 31, 2025 01:30
@sonarqubecloud
Copy link

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the MONAI Deploy App SDK version to 3.3.0 and updates documentation dependencies to newer, more flexible versions. The release adds compatibility with MONAI v1.5.1, Holoscan v3.7 CUDA12, and fixes volumetric DICOM conversion metadata consistency.

  • Version bumped from 3.2.0 to 3.3.0
  • Sphinx and related documentation dependencies updated to use version ranges instead of pinned versions
  • recommonmark dependency removed (deprecated package)

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
requirements-dev.txt Updated Sphinx, sphinx-autodoc-typehints, and sphinx-rtd-theme to flexible version ranges; removed deprecated recommonmark dependency
docs/source/release_notes/v3.3.0.md Added release notes for version 3.3.0 with MONAI v1.5.1 and Holoscan v3.7 CUDA12 compatibility
docs/source/release_notes/index.md Added v3.3.0 to the release notes table of contents
.bumpversion.cfg Updated current_version from 3.2.0 to 3.3.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

### Key changes

- Compatible with the latest MONAI v1.5.1 and Holoscan v3.7 CUDA12 version, [holoscan-cu12](https://pypi.org/project/holoscan-cu12).
- Volumentric image converted from DICOM has consistent `affine` and `space` metadata, e.g. converted image in original DICOM orientation is in `LPS`.
Copy link

Copilot AI Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected spelling of 'Volumentric' to 'Volumetric'.

Suggested change
- Volumentric image converted from DICOM has consistent `affine` and `space` metadata, e.g. converted image in original DICOM orientation is in `LPS`.
- Volumetric image converted from DICOM has consistent `affine` and `space` metadata, e.g. converted image in original DICOM orientation is in `LPS`.

Copilot uses AI. Check for mistakes.
@MMelQin MMelQin merged commit 8b61121 into main Oct 31, 2025
11 checks passed
MMelQin added a commit that referenced this pull request Oct 31, 2025
* Update release notes for v3.3.0

Signed-off-by: M Q <[email protected]>

* Update the index file

Signed-off-by: M Q <[email protected]>

* Bump version: 3.2.0 → 3.3.0

Signed-off-by: M Q <[email protected]>

---------

Signed-off-by: M Q <[email protected]>
MMelQin added a commit that referenced this pull request Oct 31, 2025
)

* Initial code for making a RESTful miscroservice with MONAI App SDK

Signed-off-by: M Q <[email protected]>

* Removed operator local fix and use newly released MONAI App SDK v3.5.1 release

Signed-off-by: M Q <[email protected]>

* Removed local copy of operator that had a temp fix

Signed-off-by: M Q <[email protected]>

* Add proper callback message

Signed-off-by: M Q <[email protected]>

* Proper json string and security fix

Signed-off-by: M Q <[email protected]>

* Fix complaints

Signed-off-by: M Q <[email protected]>

* Updated readme

Signed-off-by: M Q <[email protected]>

* Update per review comments

Signed-off-by: M Q <[email protected]>

* More update

Signed-off-by: M Q <[email protected]>

* Set header

Signed-off-by: M Q <[email protected]>

* Added packaging and running MAP of the REST service

Signed-off-by: M Q <[email protected]>

* Add app.yaml that has missed the checkin

Signed-off-by: M Q <[email protected]>

* pin monai<=1.5.0 for now as 1.5.1 has breaking changes

Signed-off-by: M Q <[email protected]>

* Add CCHMC nnUNet fifteen checkpoint application example

Signed-off-by: Elan Somasundaram <[email protected]>
Signed-off-by: chezhia <[email protected]>

* Update README documentation

Signed-off-by: Elan Somasundaram <[email protected]>
Signed-off-by: chezhia <[email protected]>

* flake8 fixed

Signed-off-by: chezhia <[email protected]>

* all tests pass

Signed-off-by: chezhia <[email protected]>

* Make affine and space metadata consistent as well as updating support of latest holoscan SDK CUDA 12 version (#565)

* Make affine and space consistent as space is properly parse by MONAI transforms

Signed-off-by: M Q <[email protected]>

* Typing improvements

Signed-off-by: M Q <[email protected]>

* Make image metadata Affine and Space consistent, either LPS or RAS

Signed-off-by: M Q <[email protected]>

* Update monai/deploy/operators/monai_seg_inference_operator.py

Co-authored-by: Copilot <[email protected]>
Signed-off-by: Ming M Qin <[email protected]>

* Correct CoPilot suggested code which failed liniting

Signed-off-by: M Q <[email protected]>

* Fix complaint from new version of mypy

Signed-off-by: M Q <[email protected]>

* Support the latest holoscan SDK CUDA 12 version, holoscan-cu12

Signed-off-by: M Q <[email protected]>

* Docs gen works with Python 3.10+

Signed-off-by: M Q <[email protected]>

* Fix complaints on single quote vs dhouble quote for string

Signed-off-by: M Q <[email protected]>

* Making docs gen require python >= 3.10

Signed-off-by: M Q <[email protected]>

* Fix docs build error on readthedocs, although local builds had no issues

Signed-off-by: M Q <[email protected]>

---------

Signed-off-by: M Q <[email protected]>
Signed-off-by: Ming M Qin <[email protected]>
Co-authored-by: Copilot <[email protected]>

* Mq/release 3.3 (#567)

* Update release notes for v3.3.0

Signed-off-by: M Q <[email protected]>

* Update the index file

Signed-off-by: M Q <[email protected]>

* Bump version: 3.2.0 → 3.3.0

Signed-off-by: M Q <[email protected]>

---------

Signed-off-by: M Q <[email protected]>

* Use string enum for status

Signed-off-by: M Q <[email protected]>

* Fix the lovely formatting complaint

Signed-off-by: M Q <[email protected]>

---------

Signed-off-by: M Q <[email protected]>
Signed-off-by: Elan Somasundaram <[email protected]>
Signed-off-by: chezhia <[email protected]>
Signed-off-by: Ming M Qin <[email protected]>
Co-authored-by: Elan Somasundaram <[email protected]>
Co-authored-by: Copilot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants