WIP: Add custom pydicom decoder using nvimgcodec #569
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: M Q <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This WIP pull request adds a custom pydicom decoder plugin using NVIDIA's nvImageCodec library to accelerate DICOM image decompression for various JPEG and JPEG2000 transfer syntaxes.
Key Changes:
- Implements a new decoder plugin in
decoder_nvimgcodec.pysupporting 9 DICOM transfer syntaxes (JPEG Baseline, Extended, Lossless, JPEG2000, and HTJ2K variants) - Integrates the decoder into
DICOMSeriesToVolumeOperatorto automatically register the plugin during initialization - Exposes the decoder module through the operators package interface
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
monai/deploy/operators/decoder_nvimgcodec.py |
New decoder plugin implementation with GPU-accelerated DICOM decompression using nvImageCodec, including registration logic and pydicom integration |
monai/deploy/operators/dicom_series_to_volume_operator.py |
Adds automatic registration of nvImageCodec decoder plugin in operator initialization |
monai/deploy/operators/__init__.py |
Exports the new nvimgcodec_handler module and adds it to all for public API |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: M Q <[email protected]>
Signed-off-by: M Q <[email protected]>
Signed-off-by: M Q <[email protected]>
Signed-off-by: M Q <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This WIP pull request adds a custom pydicom decoder plugin using NVIDIA's nvImageCodec library to accelerate DICOM image decompression for various JPEG and JPEG2000 transfer syntaxes.
Key Changes: