Skip to content

Conversation

DennisOSRM
Copy link
Collaborator

Mininum compiler version required to compile Node 16+ is GCC 8.3 according to the NodeJS release announcement.

CXXCOMPILER: g++-8
CXXFLAGS: -Wno-cast-function-type

- name: gcc-7-release
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably can add gcc-12 instead in separate PR

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, good call with the separate PR. It seems the code doesn't compile cleanly with GCC12, yet. Limited testing started to throw a fair amount of compile errors.

@SiarheiFedartsou
Copy link
Member

Mininum compiler version required to compile Node 16+ is GCC 8.3 according to the NodeJS release announcement.

Btw as I understand GCC 8 is minimum compiler version, but not required, i.e. nothing prevents us from using the very latest version of GCC to build bindings when we do it on our own(we actually use clang to do it btw), i.e. the only value of old compilers support is the fact that we enable other people to build OSRM(and probably Node bindings) with these compilers.

@DennisOSRM DennisOSRM marked this pull request as ready for review November 6, 2022 14:07
@DennisOSRM DennisOSRM merged commit 2ea168c into master Nov 6, 2022
@DennisOSRM DennisOSRM deleted the dl_drop_gcc7 branch November 6, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants