feat(drive): add ClientUID support for draft ownership tracking#201
Open
tomholford wants to merge 1 commit intoProtonMail:masterfrom
Open
feat(drive): add ClientUID support for draft ownership tracking#201tomholford wants to merge 1 commit intoProtonMail:masterfrom
tomholford wants to merge 1 commit intoProtonMail:masterfrom
Conversation
Add ClientUID field to Drive API types per official Proton Drive OpenAPI spec: - CreateFileReq.ClientUID: identifies which client created a file draft - CheckAvailableHashesReq.ClientUID: filters pending drafts by client UIDs - CheckAvailableHashesRes/PendingHashData: returns draft ownership info This enables clients to: - Safely auto-replace their own failed upload drafts - Avoid overwriting concurrent uploads from other clients Reference: ProtonDriveApps/sdk driveTypes.ts (auto-generated from OpenAPI)
0b89e7d to
315073b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
ClientUIDfield to Drive API types per official Proton Drive OpenAPI spec.This is a step towards resolving henrybear327/Proton-API-Bridge#16
Changes
CreateFileReq.ClientUID: identifies which client created a file draftCheckAvailableHashesReq.ClientUID: filters pending drafts by client UIDsCheckAvailableHashesRes/PendingHashData: returns draft ownership infoWhy
Enables clients to:
This is critical for reliable file uploads - when an upload fails partway through, it leaves an orphaned draft. Without ClientUID, clients cannot distinguish between:
Reference
These types match the official ProtonDriveApps/sdk
driveTypes.tswhich is auto-generated from the Proton Drive OpenAPI spec: