refactor!: migrate from ProtonMail/resty fork to upstream resty/v2#213
Open
mcanevet wants to merge 1 commit intoProtonMail:masterfrom
Open
refactor!: migrate from ProtonMail/resty fork to upstream resty/v2#213mcanevet wants to merge 1 commit intoProtonMail:masterfrom
mcanevet wants to merge 1 commit intoProtonMail:masterfrom
Conversation
mcanevet
force-pushed
the
feat/upstream-resty
branch
from
73641f4 to
f2c5157
Compare
Upstream resty v2.16.4+ added resetFieldReaders() (PR #953, Jan 2025), making the fork unnecessary. bytes.Reader implements io.ReadSeeker which upstream uses for retry via Seek(0, 0) — equivalent to the fork's GetMultipartReader() for static byte data. Effectively reverts the fork dependency introduced in 933cd67 (GODT-3012), replacing MultiPartStream with bytes.NewReader + SetRetryResetReaders(true). BREAKING CHANGE: UploadBlock signature changed from resty.MultiPartStream to io.ReadSeeker.
mcanevet
force-pushed
the
feat/upstream-resty
branch
from
989cf19 to
596c6bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream resty v2.16.4+ added resetFieldReaders() (PR #953, Jan 2025), making the fork unnecessary. bytes.Reader implements io.ReadSeeker which upstream uses for retry via Seek(0, 0) — equivalent to the fork's GetMultipartReader() for static byte data.
Effectively reverts the fork dependency introduced in 933cd67 (GODT-3012), replacing MultiPartStream with bytes.NewReader + SetRetryResetReaders(true).
BREAKING CHANGE: UploadBlock signature changed from resty.MultiPartStream to io.ReadSeeker.