Build process improvements to facilitate offline builds#441
Open
Cimbali wants to merge 2 commits intoProtonMail:masterfrom
Open
Build process improvements to facilitate offline builds#441Cimbali wants to merge 2 commits intoProtonMail:masterfrom
Cimbali wants to merge 2 commits intoProtonMail:masterfrom
Conversation
Cimbali
force-pushed
the
offline-build
branch
from
644cdf6 to
b49ec83
Compare
13 tasks
Requires adding FIND_PACKAGE_ARGS argument This allows to avoid downloading on offline build systems. Also don’t include googletest framework in install bundle (!)
Allows to simplify vendoring for offline build. Toolchain configuration set from build scripts where vcpkg is already used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a build process where the system is required to be offline (I think it’s the case for many distros package building?). While it’s easy enough to vendor all the go and vcpkg dependencies, I’m proposing 2 changes here in the build configuration which change nothing to the current process but greatly facilitate building offline.
INSTALL_GTESTtoOFFto avoid installing test files.vcpkgbinary during CMake as it’s only used before inbuild.sh/build.ps1. As long as the dependent libraries are found (downloaded frombuildscripts, or in my case vendored) no additional checks are needed. Similarly I moved the toolchain file definition to said build script.