Skip to content

remove av_frame_get_best_effort_timestamp #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
markreidvfx opened this issue Oct 29, 2013 · 3 comments
Closed

remove av_frame_get_best_effort_timestamp #13

markreidvfx opened this issue Oct 29, 2013 · 3 comments
Assignees
@markreidvfx
Labels
bug

Comments

@markreidvfx
Copy link
Contributor

I don't think we can rely on av_frame_get_best_effort_timestamp to get the frame pts, if we have to be compatibility with libav. I seems only ffmpeg has it.

I have this http://dranger.com/ffmpeg/tutorial05.html implemented in one of my branches, I'll try bringing it back.
@ghost ghost assigned markreidvfx Oct 29, 2013
@mikeboers
Copy link
Member

As far as I can tell, the best_effort_timestamp is set to the return value from guess_correct_pts.

See definition and usage of guess_correct_pts.

@markreidvfx
Copy link
Contributor Author

ah I see. guess_correct_pts was originally in cmdutil.c libav

ffmpeg promoted it into avcodec, avlib has not. commit moving it

@mikeboers
Copy link
Member

This discussion transitioned to #35 a while ago.

@ArtanisCV ArtanisCV mentioned this issue Jun 26, 2019
Closed
@woodenwatcher woodenwatcher mentioned this issue Mar 30, 2020
Closed
WyattBlue added a commit to johanjeppsson/PyAV that referenced this issue Nov 9, 2023
@WyattBlue
Merge pull request PyAV-Org#13 from daveisfera/upgrade_actions
f056e8d 
Upgrade actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markreidvfx markreidvfx

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikeboers @markreidvfx