Allow extradata to be set for encoders #1526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daveisfera
force-pushed
the
extradata_allow_encoder
branch
4 times, most recently
from
45a3561 to
7e1166d
Compare
daveisfera
force-pushed
the
extradata_allow_encoder
branch
from
7e1166d to
a0150d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I dug into the issue I was having with using
time_basewithadd_streamand the issue was that I was using an encoder so I could specifyextradata, but in hindsight, that was a problematic workaround and not a real solution. This PR allows settingextradatawith an encoder, so I can uselibx264instead ofh264withadd_streamso it will work as expected