Index opaque by id and make key_frame writable
#1965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WyattBlue
force-pushed
the
patch
branch
5 times, most recently
from
73ebad5 to
ce6895c
Compare
WyattBlue
changed the title
key_frame writablekey_frame writable
daveisfera
reviewed
Jul 22, 2025
| self.ptr.duration = 0 | ||
| else: | ||
| self.ptr.duration = value | ||
| self.ptr.duration = value |
There was a problem hiding this comment.
You changed the typing to be just int and removed the handling of None, so shouldn't one of those changes be reverted?
There was a problem hiding this comment.
This matches the changes I've made in BasswoodAV. I believe this fixes all contradictions in the docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.