Closed
Conversation
fsouza
reviewed
Aug 23, 2022
Collaborator
fsouza
left a comment
fsouza
left a comment
There was a problem hiding this comment.
Thanks for contributing! I just finished migrating CI to GitHub Actions, would you mind rebasing your PR? Then I can merge it.
fsouza
added a commit
that referenced
this pull request
Aug 23, 2022
Also run it in CI. Not adding pyupgrade here, as this will likely be done in #111. Aside from reorder-python-imports, I'm not adding any formatters (even though I truly like black and add-trailing-comma).
fsouza
added a commit
that referenced
this pull request
Aug 24, 2022
Python 3.6 (and 2) are no longer supported, so we can require Python 3.7 and drop all the legacy stuff. Supersedes #111.
Merged
fsouza
added a commit
that referenced
this pull request
Aug 24, 2022
Python 3.6 (and 2) are no longer supported, so we can require Python 3.7 and drop all the legacy stuff. Supersedes #111.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
py3.6 and before is deprecated now. this is a new repo to me, so let me know if i missed something!
i started with
pyupgrade --py37-plus autoflake.pyetc, and then did some modifications manually