Merged
Conversation
GrozniyToaster
force-pushed
the
add_config_file_option
branch
from
b46b1c9 to
fb79619
Compare
GrozniyToaster
force-pushed
the
add_config_file_option
branch
from
24c6034 to
231d968
Compare
fsouza
reviewed
Sep 28, 2022
README.md
Outdated
| -v, --verbose print more verbose logs (you can repeat `-v` to make it more verbose) | ||
| --stdin-display-name STDIN_DISPLAY_NAME | ||
| the name used when processing input from stdin | ||
| --config-file CONFIG_FILE |
Collaborator
There was a problem hiding this comment.
Can you make it just --config and add tests?
GrozniyToaster
force-pushed
the
add_config_file_option
branch
from
a4c72c9 to
2bc6f1d
Compare
for more information, see https://pre-commit.ci
fsouza
reviewed
Oct 3, 2022
Collaborator
fsouza
left a comment
fsouza
left a comment
There was a problem hiding this comment.
One last thing, otherwise looks good!
| "off": False, | ||
| } | ||
|
|
||
| if getattr(args, "config_file", None): |
Collaborator
There was a problem hiding this comment.
Since this is an argparse Namespace, we don't need getattr:
Suggested change
| if getattr(args, "config_file", None): | |
| if args.config_file: |
Contributor
Author
There was a problem hiding this comment.
Yes, I also wrote that, but the tests did not pass
Because in most tests the Namespace is passed without the config_file field.
(Crashes with AttributeError: 'Namespace' object has no attribute 'config_file')
Collaborator
There was a problem hiding this comment.
Gotcha, I think that's a problem with the tests. I can work on that after merging.
fsouza
approved these changes
Oct 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refer to 149 issue