Add upper limit to pyflake's version <3.0 to support handling of python 2.x # type: comments#186
Merged
fsouza merged 1 commit intoPyCQA:mainfrom Nov 24, 2022
Merged
Conversation
The latest pyflake version removed handling of python 2.x ``# type:`` comments. It would be very convenient to have a last release that support it in autoflake. As the dependency was not upper limited none of the current release of autoflake handle's 2.X style typing.
# type: comments
Member
|
It seem that the supported version is 3.7 so something like this, which would have worked without a major release if python 3.5 was still supported would not make a lot of sense: Beside 2.x style typing can still be used in python version > 3.5. I think releasing a major with |
|
For those who use pre-commit with autoflake, |
fsouza
approved these changes
Nov 24, 2022
Contributor
Author
|
Thank you for the quick release 👌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest pyflake version removed handling of python 2.x
# type:comments. As the dependency was not upper limited in release of autoflake, none of the available release of autoflake handle's 2.X style typing. It would be very convenient to have a last release that support it in autoflake before allowing pyflake > 3.0 again.