Merged
Conversation
jakkdl
approved these changes
Mar 10, 2023
jakkdl
left a comment
jakkdl
left a comment
There was a problem hiding this comment.
Looks good to me, and works with the example on my end~
When removing unused imports or breaking up lines, keep the original order. Users can use other linters/formatters to fix import order (e.g. isort or reorder-python-imports). Closes #229.
fsouza
force-pushed
the
dont-sort-imports
branch
from
c04b6f7 to
c136ba5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When removing unused imports or breaking up lines, keep the original order.
Users can use other linters/formatters to fix import order (e.g. isort or reorder-python-imports).
Closes #229.