reflected exclude option when use glob#44
Merged
myint merged 2 commits intoPyCQA:masterfrom Jan 18, 2019
Merged
Conversation
sh4869
changed the title
sh4869
force-pushed
the
fix/exlucde-on-glob
branch
from
859138f to
09fb389
Compare
sh4869
force-pushed
the
fix/exlucde-on-glob
branch
from
09fb389 to
0eb43b5
Compare
Member
|
Sounds good to me. Please add a unit test for this functionality. Thanks! |
Contributor
Author
|
I added a unit test for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When use
--excludeoption and glob pattern (ex:test/**.py) , exclude option is not reflected. I think exclude option should be reflected when specify files as same as specify folder.