Add random.Random to B311 checks
#940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lowercase `random.random` already matches `random.Random` on Windows as well (due to being case-insensitive), but not on other platforms. Resolves: PyCQA#926
shiftinv
requested review from
ericwb,
lukehinds and
sigmavirus24
as code owners
|
Hi! Friendly ping. The inconsistency across platforms is inconvenient when running automated checks against multiple platforms. |
skshetry
added a commit
to iterative/dvc
that referenced
this pull request
Jul 3, 2023
See PyCQA/bandit#940. Will not be needed when new version of bandit comes.
skshetry
added a commit
to iterative/dvc
that referenced
this pull request
Jul 3, 2023
See PyCQA/bandit#940. Will not be needed when new version of bandit comes.
charliermarsh
pushed a commit
to astral-sh/ruff
that referenced
this pull request
Mar 11, 2024
…S605` (#10313) ## Summary Pick up updates made in latest [releases](https://github.com/PyCQA/bandit/releases) of `bandit`: - `S311`: PyCQA/bandit#940 and PyCQA/bandit#1096 - `S324`: PyCQA/bandit#1018 - `S605`: PyCQA/bandit#1116 ## Test Plan Snapshot tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lowercase
random.randomalready matchesrandom.Randomon Windows as well(due to being case-insensitive), but not on other platforms.
Resolves #926.