B024: don't warn on classes without methods #336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakkdl
force-pushed
the
B024_empty_abstract_class
branch
from
86ef281 to
36d815a
Compare
|
The error message in the readme and the message being raised were very different, so synced them to match better, and updated the message to be "softer". |
Zac-HD
approved these changes
Jan 18, 2023
There was a problem hiding this comment.
Looks good to me, thanks @jakkdl!
cc @cooperlees in case you want to review, or plan a release?
cooperlees
reviewed
Jan 18, 2023
Zac-HD
reviewed
Jan 18, 2023
jakkdl
force-pushed
the
B024_empty_abstract_class
branch
from
36d815a to
506f785
Compare
the error message, and changed the message in the README to match it better.
jakkdl
force-pushed
the
B024_empty_abstract_class
branch
from
506f785 to
8116fdb
Compare
|
Fixed review comments and rebased on top of main |
Zac-HD
reviewed
Jan 19, 2023
Yup, much clearer. Co-authored-by: Zac Hatfield-Dodds <[email protected]>
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix another case in #278 - so now it won't warn on empty classes or any class without methods, esp since the fix proposed in the error message (consider adding
@abstractmethod) is not useful in that case.@Zac-HD @mikhail-melnik