(3.8) Replace deprecated ast literals #366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh right, we might want to disable the 3.7 CI run first 🤦 |
Maybe we should do this in a PR we land before this turning off CI, adjusting pyproject.toml and anything else that ups our minimums for tools ... Also happy for this all to be 1 PR ... Doesn't seem it will be to large, just that if the new ast literals have bugs it's a cleaner revert ... |
|
@cooperlees Just read my mind, submitting a PR for that now. |
I'm around for a few hours so can merge quickly to make rebasing this easier. |
FozzieHi
force-pushed
the
3-8-deprecated
branch
from
da86bdc to
ef7cd27
Compare
cooperlees
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue: #365
See python/cpython#77073:
This looks a bit messy in places but I don't think a helper function would provide that much improved readability (it'd effectively just be re-implementing the deprecation's, which we don't want), and we only use this in a relatively small portion of the code base.
I've just replaced the deprecated literals with their actual meanings, I'm not too sure whether we now want to change some (for example ast.Num checks for int, float and complex but we might only want to check for int).