Unindented comments get malformed

[mattmess1221]

isort version: 5.10.1

Unindented comments in an indented block seem to get cut off at the indent, which generates a syntax error.

Code:

import sys

if True:
# this will get cut off
    import os

Output:

import sys

if True:
is will get cut off
    import os

[anirudnits]

Hello @killjoy1221, thanks for raising this! I can verify that this a bug and apparently happens with all the default settings. I'll investigate the root cause for this and try to resolve it. Thanks again for flagging this

[anirudnits]

I have created a PR and for the time being added a failing test to keep this issue active and am working to resolve this

[anirudnits]

I identified the root cause of the problem:

isort/isort/core.py

Lines 411 to 414 in c6a4196

	if indent:
	import_section = "".join(
	line[len(indent) :] for line in import_section.splitlines(keepends=True)
	)

The line[len(indent): ] portion is causing the initial part of the un-indented comment to be cut off. The simple solution is change the above section to line.strip() or equivalent, however with that some other tests are failing. I'm looking into this and debugging the failed tests as well to understand the cause there.