Skip to content
This repository was archived by the owner on Nov 3, 2023. It is now read-only.

Fix appveyor builds #415

Merged
merged 2 commits into from
Oct 21, 2019
Merged

Fix appveyor builds #415

merged 2 commits into from
Oct 21, 2019

Conversation

sambhav
Copy link
Member

@sambhav sambhav commented Oct 13, 2019

Thanks for submitting a PR!

Please make sure to check for the following items:

  • Add unit tests and integration tests where applicable.
    If you've added an error code or changed an error code behavior,
    you should probably add or change a test case file under tests/test_cases/ and add
    it to the list under tests/test_definitions.py.
    If you've added or changed a command line option,
    you should probably add or change a test in tests/test_integration.py.
  • Add a line to the release notes (docs/release_notes.rst) under "Current Development Version".
    Make sure to include the PR number after you open and get one.

Please don't get discouraged as it may take a while to get a review.

@sambhav sambhav force-pushed the appveyor-fix branch 6 times, most recently from 92424fe to b54f90d Compare October 13, 2019 10:09
@sambhav
Copy link
Member Author

sambhav commented Oct 13, 2019

See discussion on tox-dev/tox#791

Basically tox is using a really old version of pip which doesn't support some newer features required by our deps.

@sambhav
Copy link
Member Author

sambhav commented Oct 13, 2019

@Nurdok all the appveyor builds are failing. Please merge this so the other PRs pass.

@Nurdok Nurdok merged commit 4e39a57 into PyCQA:master Oct 21, 2019
@Nurdok
Copy link
Member

Nurdok commented Oct 21, 2019

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants