Skip to content

fix another unsafe_op_in_unsafe_fn trigger #4753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LilyFirefly merged 1 commit into from
Dec 2, 2024
Merged

fix another unsafe_op_in_unsafe_fn trigger #4753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pyo3-macros-backend/src/params.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,9 +262,10 @@ pub(crate) fn impl_regular_arg_param(
)?
}
} else {
let unwrap = quote! {unsafe { #pyo3_path::impl_::extract_argument::unwrap_required_argument(#arg_value) }};
quote_arg_span! {
#pyo3_path::impl_::extract_argument::from_py_with(
#pyo3_path::impl_::extract_argument::unwrap_required_argument(#arg_value),
#unwrap,
#name_str,
#from_py_with as fn(_) -> _,
)?
Expand Down
12 changes: 12 additions & 0 deletions tests/ui/forbid_unsafe.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,16 @@ mod gh_4394 {
pub struct Version;
}

mod from_py_with {
use pyo3::prelude::*;
use pyo3::types::PyBytes;

fn bytes_from_py(bytes: &Bound<'_, PyAny>) -> PyResult<Vec<u8>> {
Ok(bytes.downcast::<PyBytes>()?.as_bytes().to_vec())
}

#[pyfunction]
fn f(#[pyo3(from_py_with = "bytes_from_py")] _bytes: Vec<u8>) {}
}

fn main() {}
Loading