release: 0.23.4 #4835
Merged
release: 0.23.4 #4835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* eagerly complete once in normalized error state * newsfragment
This can lead to code execution. See https://woodruffw.github.io/zizmor/audits/#template-injection for details
* Fix chrono deprecation warning * use allow(deprecated) instead --------- Co-authored-by: Nathan Goldbaum <[email protected]>
* fix `chrono::DateTime<Tz>` intoPyObject conversion * Add test
#4791) * use `datetime.fold` to distinguish ambiguous datetimes when converting * Set correct fold when converting to ambiguous `chrono::DateTime<Tz>`
* Fix struct layouts on GraalPy * Add changelog item
* fix: cross-compilation compatibility checks for Windows * add newsfragments * add simple test
* Expand docs on when and why allow_threads is necessary * spelling * simplify example a little * use less indirection in the example * Update guide/src/parallelism.md * Add note about the GIL preventing parallelism * Update guide/src/free-threading.md Co-authored-by: Bruno Kolenbrander <[email protected]> * pared down text about need to use with_gil * rearrange slightly --------- Co-authored-by: Bruno Kolenbrander <[email protected]>
* clarify safety docs for PyDict API * get dict size using PyDict_Size on free-threaded build * avoid unnecessary critical sections in PyDict * add changelog entry * fix build error on GIL-enabled build * address code review comments * move attribute below doc comment * ignore unsafe_op_in_unsafe_fn in next_unchecked --------- Co-authored-by: David Hewitt <[email protected]>
davidhewitt
force-pushed
the
release-0.23.4
branch
from
b5ff046 to
5dbfe61
Compare
* implement locked iteration for PyList
* fix limited API and PyPy support
* fix formatting of safety docstrings
* only define fold and rfold on not(feature = "nightly")
* add missing try_fold implementation on nightly
* Use split borrows for locked iteration for PyList
Inline ListIterImpl implementations by using split borrows and
destructuring let Self { .. } = self destructuring inside
BoundListIterator impls.
Signed-off-by: Manos Pitsidianakis <[email protected]>
* use a function to do the split borrow
* add changelog entries
* fix clippy on limited API and PyPy
* use a macro for the split borrow
* add a test that mutates the list during a fold
* enable next_unchecked on PyPy
* fix incorrect docstring for locked_for_each
* simplify borrows by adding BoundListIterator::with_critical_section
* fix build on GIL-enabled and limited API builds
* fix docs build on MSRV
---------
Signed-off-by: Manos Pitsidianakis <[email protected]>
Co-authored-by: Manos Pitsidianakis <[email protected]>
* Fix failing ruff fmt test * Add newsfragments * remove changelog * use wasm32-wasip1 in CI * update ui tests * use `wasm32-wasip1` in noxfile * update one more ui test * fix clippy beta * bump `EMSCRIPTEN_VERSION` * emscripten link `sqlite3` * emscipten update node --------- Co-authored-by: Nathan Goldbaum <[email protected]> Co-authored-by: Icxolu <[email protected]>
|
Thank you everyone for the continued progress. I've now pulled all the fixes since I previously pushed this branch, and if CI is green I'll probably put this live tonight. |
|
I see the clippy beta failure but that looks like a clippy bug? So I'll release this regardless tonight. |
Yep, I think this will be the fix rust-lang/rust-clippy#13953 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there's a lot of fixes accumulated which are worth shipping independently of any motion we have towards 0.24.
Thanks to everyone who has been reporting / investigating / authoring / reviewing these while I have been mostly occupied with family concerns through December. Happy New Year, and here's to further progress for PyO3 in 2025 🚀 🎉
I will wait for #4789 and then complete this release.