unify IntoPyObject/FromPyObject derive attributes
#5070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Icxolu
force-pushed
the
fix/4884
branch
3 times, most recently
from
11313a0 to
bb3560d
Compare
Closed
davidhewitt
approved these changes
May 4, 2025
There was a problem hiding this comment.
Thanks, this looks great to me! It's slightly unfortunate that if a user writes just #[derive(IntoPyObject)] and then adds a load of attributes only specific to #[derive(FromPyObject)] they are (often) just silently ignored, but it seems there is no better alternative (and the same as serde).
Comment on lines
+20
to
+21
| /// Converts the field idents according to the [RenamingRule](attributes::RenamingRule) before extraction | ||
| RenameAll(RenameAllAttribute), |
There was a problem hiding this comment.
Should this be supported for IntoPyObject? I guess a separate follow-up issue.
There was a problem hiding this comment.
Probably, will have a look 👍
|
@davidhewitt any idea which release this will release in? |
|
See #5107 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This combines the attributes of the
IntoPyObjectandFromPyObjectderive macros, such that individual options can still be used when deriving both.Closes #4884