Fixes pytests tests when using Python 3.7 #5095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #5025 (comment) No changelog, the test has been introduced in an unreleased change |
|
Closing and reopening to trigger the |
ngoldbaum
reviewed
Apr 25, 2025
Tpt
changed the title
ngoldbaum
reviewed
Apr 25, 2025
Co-authored-by: Nathan Goldbaum <[email protected]>
|
Seems to have fixed the 3.7 build, thanks! Added to the queue. |
newcomertv
pushed a commit
to newcomertv/pyo3
that referenced
this pull request
Apr 28, 2025
* Disable positional only test in Python 3.7 * Update pytests/tests/test_pyfunctions.py Co-authored-by: Nathan Goldbaum <[email protected]> * fix ruff --------- Co-authored-by: Nathan Goldbaum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Positional-only arguments are not allowed in Python 3.7