Merged
Conversation
Icxolu
force-pushed
the
deprecate/pyobject
branch
from
e6b91e2 to
30c1139
Compare
Member
|
👍 I think we should do this; with known reasons to cause confusion I agree that the alias does more harm than good. I think that this is probably safe to send in 0.26, then the release continues to carry its theme as "a name cleanup". I am cautious about putting much else at all into 0.27 given how the Let's add a migration guide entry? |
Icxolu
force-pushed
the
deprecate/pyobject
branch
from
30c1139 to
ed14f13
Compare
Contributor
Author
|
Great! I've added the migration entry |
LilyFirefly
approved these changes
Aug 15, 2025
Icxolu
force-pushed
the
deprecate/pyobject
branch
from
6e5a8de to
5994dca
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This deprecates the
PyObjecttype alias forPy<PyAny>. This alias is confused easily withpyo3_ffi::PyObject, last time #4434 (comment).This may fit nicely with all the other renaming cleanups in 0.26, but I'm also fine postponing until 0.27 if we think it's to much.