Introspection: emit doc comments#5782
Merged
davidhewitt merged 2 commits intoPyO3:mainfrom Feb 14, 2026
Merged
Conversation
Tpt
commented
Feb 5, 2026
Still missing is the support of enum variant and constants doc comments Notable changes: - get_doc() now returns an intermediate structure. The `to_cstr_stream` returns the expected cstr - get_doc() returns now an option when there is no doc - erroring on nul byte is delegated to `cstr!` - PyMemberDef.doc is now set to NULL if there is no doc instead of the empty string (NULL is allowed by cpython doc) - same for PyGetSetDef.doc
32 tasks
davidhewitt
reviewed
Feb 12, 2026
Member
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
Thanks, I have one initial thought which might influence the rest of the review.
davidhewitt
approved these changes
Feb 14, 2026
Member
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
Thanks, this is a great improvement!
Sorry to take some time to review, kept coming back to this in multiple sessions.
Contributor
Author
|
@davidhewitt This is a very big MR, thank you fog going through it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notable changes:
to_cstr_streamfunction returns the expected cstr