Support cbor2 6 - #503
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #503 +/- ##
==========================================
+ Coverage 90.73% 90.79% +0.05%
==========================================
Files 37 37
Lines 5356 5422 +66
Branches 808 825 +17
==========================================
+ Hits 4860 4923 +63
- Misses 308 309 +1
- Partials 188 190 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
CBOR compatibility is an obstacle to simplifying dependencies in our defi-kernel trading engine: we currently pin cbor2 below 6 with a pure-Python build, and Dendrite pins PyCardano 0.18.0. We’re interested in this work landing with byte-exact transaction/datum preservation and a clear supported-version path; we’ll track this thread rather than open a duplicate. |
cffls
left a comment
There was a problem hiding this comment.
Thanks, this is huge! Looks like it is backward incompatible, should be released with a major version bump I guess.
|
Yes should neither introduce new behavior nor break old behavior. |
Depends on #502 (
fix/ci-pytest-command). That PR should be merged first; once it lands inmain, this PR will contain only the cbor2 6 changes.Summary