Skip to content

added support for new testnets in blockfrost #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 25, 2022

Conversation

mateusap1
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2022

Codecov Report

Merging #80 (c469764) into main (e4f9d1c) will increase coverage by 0.01%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
+ Coverage   86.00%   86.02%   +0.01%     
==========================================
  Files          23       23              
  Lines        2444     2447       +3     
  Branches      551      551              
==========================================
+ Hits         2102     2105       +3     
  Misses        252      252              
  Partials       90       90              
Impacted Files Coverage Δ
pycardano/backend/blockfrost.py 30.97% <50.00%> (ø)
pycardano/network.py 86.66% <100.00%> (+3.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mateusap1
Copy link
Contributor Author

mateusap1 commented Aug 25, 2022

Not sure if this is the best approach to deal with the new testnets (preprod and review). Another alternative would be to call them all Network.TESTNET (since they share some "testnet" simmilarities like the address format), but require (or allow) user to specify the blockfrost URL.

@mateusap1
Copy link
Contributor Author

Yeah, I see address derivation is failing with my addition.
Address(payment_vkey.hash(), stake_vkey.hash(), network=Network.PREPROD) is giving a different value from Address(payment_vkey.hash(), stake_vkey.hash(), network=Network.TESTNET) which is not good
Maybe mantaining the same networks, but allowing a custom blockfrost url is actually the best option

Copy link
Collaborator

@cffls cffls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the change!

@cffls cffls merged commit 37ed19e into Python-Cardano:main Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants