-
Notifications
You must be signed in to change notification settings - Fork 52
feat: add i18n support #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This feature includes the core functions added to /internal, English and Hebrew json files, removal of text strings from the html files, updates to the routes and model updates. Also included are tests. Please note, that this feature is waiting on user registration for final hooks.
… move foreignkey to last column as requested in CR. Additional minor doc fixes.
Codecov Report
@@ Coverage Diff @@
## main #115 +/- ##
==========================================
+ Coverage 98.72% 98.88% +0.15%
==========================================
Files 10 11 +1
Lines 236 269 +33
==========================================
+ Hits 233 266 +33
Misses 3 3
Continue to review full report at Codecov.
|
This change hopefully adds this line to the code coverage.
This change reduces the amount of imports needed and also uses one dir path for both tests and live.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. Added some of my insights.
… and "localized" and the creation of the Jinja2TemplateResponse is now handled in internal/utilities.
The translations are now handled with @lru_cache and the function is only re-handled when a new language code parameter is used. This should be the last edit (unless any crash) to this version of the translation feature.
Changed i18n system as requested in code review.
@yammesicka any idea on how to handle the missing code coverage where I do a test to check if I'm running from tests or live? A few notes:
|
Awesome work! Can you please add this to the workflow? We can do it automagically using GitHub Actions. |
Fixed missing curly parenthesis in profile.html Changed _get_supported_languages() into a generator expression Merged testing parameters in test_language.py
This reverts commit 779de2d.
Hi, I've merged it by mistake, but this actually should go into the |
This feature includes the core functions added to /internal, English and Hebrew json files, removal of text strings from the html files, updates to the routes and model updates. Also included are tests. Please note, that this feature is waiting on user registration for final hooks.
Issue: #23