Skip to content

Feature/current time cursor #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

TamarBerger
Copy link
Contributor

A feature that marks the current time in the day view and the week view display.
This, in order to help the user orientate in his schedule and get a better experience:)

@codecov-io
Copy link

codecov-io commented Feb 15, 2021

Codecov Report

Merging #288 (949e7c8) into develop (1048956) will increase coverage by 0.02%.
The diff coverage is 97.29%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #288      +/-   ##
===========================================
+ Coverage    98.01%   98.04%   +0.02%     
===========================================
  Files           68       70       +2     
  Lines         2979     3016      +37     
===========================================
+ Hits          2920     2957      +37     
  Misses          59       59              
Impacted Files Coverage Δ
app/routers/event.py 96.84% <ø> (ø)
app/routers/dayview.py 94.73% <96.87%> (+0.61%) ⬆️
app/routers/weekview.py 100.00% <100.00%> (ø)
app/main.py 92.50% <0.00%> (ø)
app/internal/json_data_loader.py 100.00% <0.00%> (ø)
app/internal/jokes.py 100.00% <0.00%> (ø)
app/routers/joke.py 100.00% <0.00%> (ø)
app/database/models.py 96.77% <0.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1048956...949e7c8. Read the comment docs.

Copy link
Member

@yammesicka yammesicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start! I've added few insights :)

Copy link
Member

@yammesicka yammesicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! I've added few of my insights :)

Copy link
Member

@yammesicka yammesicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Added few new insights :)

@ivarshav
Copy link
Contributor

Please fix conflicts :)

Copy link
Member

@yammesicka yammesicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just few fixes and we're ready to merge

Copy link
Member

@yammesicka yammesicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, last pushes :)

@yammesicka yammesicka merged commit 3c22c8c into PythonFreeCourse:develop Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants