feat: gets a link to the suitable image of a given event content. #70

nir9696 · 2021-01-17T18:18:48Z

No description provided.

ivarshav · 2021-01-17T18:43:42Z

app/event_images/event_images.py

+import re
+
+
+IMAGES_LINK_MAP = {


I'd like to suggest an idea so you could discard this dict:

Rename all the images to be with exactly the same name as the key (for ex.: cycling.jpg -> cycle.jpg).

Create an auxiliary function which receives the key and generates the full path: f"event_flairs{key}.jpg".

Also, note that you are using "".
It's better to verify on which os the application is running on.
Even better - support all os platforms :)

good idea! I'll do that!

can you hint me how do I support all os platforms?

Try to google it :)

app/event_images/tests/test_event_images.py

…_MAP dict and create new func that generates the flairs link by a lemmatized word.

app/event_images/tests/test_event_images.py

app/event_images/tests_cmd.txt

app/event_images/event_images.py

yammesicka · 2021-01-18T05:02:13Z

Please send PR to PythonFreeCourse:develop instead

app/event_images/event_images.py

yammesicka · 2021-01-19T17:33:50Z

Great job! I've added 2 more comments to fix before the merge.

This reverts commit 002b7ee.

This reverts commit da3c582.

tests/test_event_images.py

app/routers/event_images.py

yammesicka · 2021-01-22T03:46:20Z

Unfortunately I had to truncate your changes to requirements.txt, as your commit added lots of unused packages (such as JupyterNotebook).

Please add only the relevant packages (if needed) to the requirements.txt file and push again.

Also, please check the following linter comments by flake8.

app/config.py

nir9696 · 2021-01-23T21:39:44Z

In the linter comments by flake8, I've got "AttributeError: module 'app.config' has no attribute 'STATIC_ABS_PATH'",
but it has! I spent many many hours to figure out what the problem is and I failed to understand this.
I saw many questions about import errors like mine in stackoverflow, with no satisfying answers... I've also tried to ask my peers in the course but I didn't get any response.
Can you help me?

yammesicka · 2021-01-23T21:46:44Z

You could ask in the forums :)

Our CI copy the config.py.example and overrides any instance of config.py.

You should put the configurations in config.py.examples.

…endar into feature/event_images # Conflicts: # app/config.py.example

…endar into feature/event_images

app/config.py.example

yammesicka · 2021-01-26T09:57:15Z

Great job, but pytest is failing during the CI. Can you please fix it?

@hadaskedar2020

* update ORM and added export for an event * update ORM and added export for an event * Added in app shareable events * docs: add type annotation and fix folder structure * docs: add type annotation and fix folder structure * docs: fix documentation * feat: get weather forecast for date and location * feat: get weather forecast for date and location * add: tests * set up commit * add: timezone support * add: session management * fix bug * split conftest file * split conftest file * move "utils" folder into "internal" folder * working day view with jinja2 template * with tests for pytest * feat: get weather forecast - fixes according to requested changes. * change file structure * feat: get weather forecast - fixes according to requested changes. * first functioning day-view html, css and router * feat: Basic responsive calender day view page Added dayview template with css and router. An tempreroy event class with, processing function for the day view to work. * feat: Basic responsive calender day view page Added dayview template with css and router. An tempreroy event class with, processing function for the day view to work. fixed after taking notes. * fix lint now for sure * more lint * feat: get weather forecast - fix requirements.txt * feat: enable invited users to view events * feat: flake8 changes * fix: requirements bug * fix: requirements bug * feat: flake8 changes * add: tests * feat: flake8 changes * add: tests * feat: flake8 changes * edit: file structure * edit: file structure * feat: get weather forecast - fix changes & add cache support * feat: get weather forecast - fix changes & add cache support * feat: get weather forecast - fix changes & add cache support * feat: add route tests * feat: get weather forecast - fix changes & add cache support * feat: get weather forecast - fix changes & add cache support * fix: test bug * remove: config.py * after all notes and started use the orm * fix: type annotation * feat: get weather forecast - add API mocking * feat: get weather forecast - add API mocking * feat: get weather forecast - add API mocking * feat: get weather forecast - add API mocking * fixed: changed "size" var in html and and more acuurate typing * deleted some testing lines * add requirements missing * add: minor changes * feat: flake8 changes * @hadaskedar2020 * feat: get weather forecast - add API mocking * feat: weather forecast - add API mocking & improve coverage * feat: weather forecast - add API mocking & improve coverage * feat: weather forecast - add API mocking & improve coverage * feat: weather forecast - add API mocking & improve coverage * feat: weather forecast - add API mocking & improve coverage * fixed: statements of event select more accurate * new test and lint fix * added more contants abd more notes taken * feat: weather forecast - move feat to internal * Delete Scripts directory * update constants * more notes * forgot white space * feat: gets a link to the suitable image of a given event content. (#70) * feat: gets a link to the suitable image of a given event content. * Add basic update event (#100) * Add basic update event * Added search feature (#98) * Added search feature * Add telegram client (#111) Add telegram client * feat: Add a feature for sharing information with a WhatsApp account (#83) * feat: Add a feature to share to a WhatsApp account * Feature/logging system (#112) * feat: first logging commit Co-authored-by: Liad Noam <[email protected]> * feat: add a daily inspirational quote (#128) * feat: add a daily inspirational quote * Feature/delete event (#139) * basic delete event * Add an event delete function * Fix flake8 * Deleting an unnecessary model * Extract lines from try * fix: modify psycopg2 dependency (#164) * Bugfix/logging system (#158) * Changed logging config to be received by separate parameters for simplicity, removed option to receive configuration as a dict, added .vscode to gitignore * removed logging_config file which is no longer needed * Fixing merge conflicts - missing whitespace on config.py.example Co-authored-by: Liad Noam <[email protected]> * Added checking for zoom link and saving the event (#122) * Added checking for zoom link and saving the event * Feature/import to calendar (#119) * feat: import file to calendar * docs: adding community standard documents (#173) * Feat: Event View Backend (#159) * Moved the route to top of file * Feature/send email (#88) * Added files for sending invitations by email This includes - templates - routes and internal code - configuration - tests Co-authored-by: leddest <[email protected]> Co-authored-by: Ellen <[email protected]> * Feature/translation - add an functionality to translate event data etc. (#167) * translation feature stuff * Update event - Improving the code (#138) * Add basic update event * Support categories for events (#137) * Support categories for events * Style/grid (#106) * Hello Wrold * Creating Html Template * Calendar dates calculation intigrating with html, HTML\CSS improvments. * Tests for calender_grid.py, changing function according to currections, fixing bugs * linting bug fixing * before merge with develop * Creating a Day object and days subclasses, changing all function and tests according to the new objects, Changing front to get information from Day objects, Re-arranging calendar.html grid stracture to be render by weeks, adding js functionality for day view section, adding css effects on daily event display * fix lintings * fix lintings * tests next week scroll * js updates * Calendar Scrolling with javascript * Fix lintings * Fix lintings * Calendar infinit scrolling ducplicates weeks bug fixed * seetings global parameters for calendar.py * Js - changing to fetch, removing jquery, fixing hint tpying, adding Week object, changing tests * Front end bug fixing * Fix linting * Fix lintings * Fix lintings * fixing syntax * Get user local date and time when enter calendar. * Fix lintings * Fix lintings * Fix lintings * Bugs fixing * Bugs fixing * Bugs fixing * Bugs fixing * JS alerts removal * Fix Lintings * Js syntext fixing * Bugs fixing * Bugs fixing * Js fixing varibales and adding div element to request. * Develop Update * Js - eliminate global parameters * Linting fixing * Fix Lintings * Fix flake8 * syntac fixing * Feature/translations workflow (#150) * feat: add translations workflow * fix(translations-workflow): fix doc * fix(translations-workflow): fixed code and added automatic commit Co-authored-by: Gonny <1@1> * Revert "Feature/translations workflow (#150)" (#208) This reverts commit 2e6a2c2. * feat: Add zodiac signs to the day & month view + refactor json data loader (#155) * feat: Add zodiac signs to the day/month view + * Change calendar link from '#' to '/' to get the home page (#194) when clicking on the logo * Style/grid (#200) * Js scrolling duplication days fixed Co-authored-by: Idan Pelled <[email protected]> Co-authored-by: Hadas Kedar <[email protected]> Co-authored-by: Sagi Zaid Or <[email protected]> Co-authored-by: sagizaidor <[email protected]> Co-authored-by: hadaskedar2020 <[email protected]> Co-authored-by: nir9696 <[email protected]> Co-authored-by: efratush <[email protected]> Co-authored-by: advaa123 <[email protected]> Co-authored-by: leddest <[email protected]> Co-authored-by: nelliei <[email protected]> Co-authored-by: Liad-n <[email protected]> Co-authored-by: Liad Noam <[email protected]> Co-authored-by: zohary89 <[email protected]> Co-authored-by: Ron Huberfeld <[email protected]> Co-authored-by: Ap1234567 <[email protected]> Co-authored-by: Nir-P <[email protected]> Co-authored-by: Ode <[email protected]> Co-authored-by: Anna Shtirberg <[email protected]> Co-authored-by: Ellen <[email protected]> Co-authored-by: ivarshav <[email protected]> Co-authored-by: Aviad <[email protected]> Co-authored-by: Gonzom <[email protected]> Co-authored-by: Gonny <1@1> Co-authored-by: YairEn <[email protected]>

feat: gets a link to the suitable image of a given event content.

07982fd

ivarshav reviewed Jan 17, 2021

View reviewed changes

app/event_images/tests/test_event_images.py Outdated Show resolved Hide resolved

nir9696 added 4 commits January 17, 2021 20:58

fix: correct minor typos in code

74c9442

fix: correct minor typos in code

3327d86

fix: change the flairs names to lemmatized named, discard IMAGES_LINK…

7479db1

…_MAP dict and create new func that generates the flairs link by a lemmatized word.

fix: correct minor typos in code

2ecc875

yammesicka requested changes Jan 18, 2021

View reviewed changes

fix: correct minor typos in code

9eee27d

nir9696 changed the base branch from main to develop January 18, 2021 17:45

fix: change the route of the feature test.

faa42c9

yammesicka requested changes Jan 19, 2021

View reviewed changes

app/event_images/event_images.py Outdated Show resolved Hide resolved

app/event_images/event_images.py Outdated Show resolved Hide resolved

nir9696 added 7 commits January 19, 2021 20:29

fix: changed path of the program and the flair images.

a853198

fix: correct minor typos in code

da3c582

fix: correct minor typos in code

002b7ee

Revert "fix: correct minor typos in code"

a5b8361

This reverts commit 002b7ee.

Revert "fix: correct minor typos in code"

8fe45d4

This reverts commit da3c582.

fix: correct minor typos in code

cb533f5

fix: correct minor typos in code

13cdd3b

PureDreamer reviewed Jan 20, 2021

View reviewed changes

tests/test_event_images.py Outdated Show resolved Hide resolved

app/routers/event_images.py Outdated Show resolved Hide resolved

yammesicka requested changes Jan 20, 2021

View reviewed changes

app/routers/event_images.py Outdated Show resolved Hide resolved

yammesicka closed this Jan 21, 2021

yammesicka deleted the branch PythonFreeCourse:develop January 21, 2021 02:36

yammesicka reopened this Jan 21, 2021

nir9696 added 4 commits January 21, 2021 16:30

fix: correct minor typos in code

ea0b7a4

fix: update requirements.txt

7fe1d3b

fix: correct minor typos in code

f770b4d

fix: add config

c57fe57

fix: correct minor typos in code

1c7a409

nir9696 force-pushed the feature/event_images branch from 1435acb to 1c7a409 Compare January 22, 2021 09:22

Merge branch 'develop' into feature/event_images

3b79d09

yammesicka requested changes Jan 23, 2021

View reviewed changes

app/config.py Outdated Show resolved Hide resolved

nir9696 and others added 6 commits January 24, 2021 17:37

fix: add config.py.example

6cc9850

Merge branch 'feature/event_images' of https://github.com/nir9696/cal…

3c83639

…endar into feature/event_images # Conflicts: # app/config.py.example

Merge branch 'develop' into feature/event_images

26c7db2

fix: correct minor typos in code

9491fed

Merge branch 'feature/event_images' of https://github.com/nir9696/cal…

94c8a65

…endar into feature/event_images

Merge branch 'develop' into feature/event_images

8eb70d7

yammesicka approved these changes Jan 26, 2021

View reviewed changes

app/config.py.example Outdated Show resolved Hide resolved

nir9696 added 4 commits January 26, 2021 19:46

fix: update environment and thus requirements.txt

e58433e

fix: correct minor typos in code

24a70ef

fix: correct minor typos in code

ca63267

fix: correct minor typos in code

122962f

yammesicka merged commit b119281 into PythonFreeCourse:develop Jan 27, 2021

		import re


		IMAGES_LINK_MAP = {

feat: gets a link to the suitable image of a given event content. #70

feat: gets a link to the suitable image of a given event content. #70

Uh oh!

Conversation

nir9696 commented Jan 17, 2021

Uh oh!

ivarshav Jan 17, 2021

Choose a reason for hiding this comment

Uh oh!

nir9696 Jan 17, 2021

Choose a reason for hiding this comment

Uh oh!

nir9696 Jan 18, 2021

Choose a reason for hiding this comment

Uh oh!

ivarshav Jan 21, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yammesicka commented Jan 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yammesicka commented Jan 19, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yammesicka commented Jan 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

nir9696 commented Jan 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yammesicka commented Jan 23, 2021

Uh oh!

Uh oh!

yammesicka commented Jan 26, 2021

Uh oh!

Uh oh!

yammesicka commented Jan 18, 2021 •

edited

Loading

yammesicka commented Jan 22, 2021 •

edited

Loading

nir9696 commented Jan 23, 2021 •

edited

Loading