Harden msgr2.1 frame segment length checks #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Harden msgr2.1 frame segment length checks in libceph.
This patch applies the upstream change from commit[
a282a2f10539dce2aa619e71e1817570d557fc97(https://github.com/torvalds/linux/commit/a282a2f10539dce2aa619e71e1817570d557fc97).Details
decode_preamble(), becauseceph_frame_desc::fd_lensis an int array and previously unsigned-style checks could allow invalid values.Context
Original commit was authored by Ilya Dryomov and merged upstream to correct frame segment checks that assumed unsigned lengths. The fix prevents potential malformed or malicious msgr2.1 input from bypassing validation due to incorrect type handling.
Impact
Improves robustness and correctness of Ceph msgr2.1 frame parsing.