Skip to content

ENH: adjust uri to use provided source folders for jupyter_download_nb #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

ENH: adjust uri to use provided source folders for jupyter_download_nb #264

wants to merge 4 commits into from

Conversation

mmcky
Copy link
Contributor

@mmcky mmcky commented Aug 28, 2019 •
edited
Loading

This PR adjusts the URI when using the jupyter_download_nb_image_urlpath to use _static paths adjusted for / and relative ../ conditions without having to specify incorrect paths in conf.py option jupyter_static_file_path

@mmcky mmcky added this to the v0.4.4 milestone Aug 28, 2019
@mmcky mmcky requested a review from AakashGfude August 28, 2019 01:33
@mmcky mmcky changed the title ENH: adjust uri to use provided source folders ENH: adjust uri to use provided source folders for jupyter_download_nb Aug 28, 2019
@mmcky
Copy link
Contributor Author

mmcky commented Aug 28, 2019

@mmcky
Copy link
Contributor Author

mmcky commented Aug 28, 2019 •
edited
Loading

  • needs testing as on a build of lecture-source-py this appears to be using url links rather than relative links for non-download pages in website/jupyter/

[about_py]

https://s3-ap-southeast-2.amazonaws.com/lectures.quantecon.org/py/_static/lecture_specific/about_py/python_vs_rest.png

the download set also has the url prefix.

@mmcky mmcky added test and removed in-review labels Aug 28, 2019
@mmcky mmcky added the on-hold label Aug 30, 2019
@mmcky
Copy link
Contributor Author

mmcky commented Sep 3, 2019

This is unlikely to be merged as we will pursue #266

@mmcky mmcky added the wontfix label Sep 10, 2019
@mmcky mmcky closed this Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AakashGfude AakashGfude AakashGfude approved these changes

Assignees
No one assigned
Labels
on-hold test wontfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmcky @AakashGfude